Skip to content

fix(web): simplify pull request summary sections - #10612

Open
maria-rcks wants to merge 11 commits into
pingdotgg:mainfrom
maria-rcks:t3code/compact-pull-request-details
Open

fix(web): simplify pull request summary sections#10612
maria-rcks wants to merge 11 commits into
pingdotgg:mainfrom
maria-rcks:t3code/compact-pull-request-details

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

The pull request summary used too much space for metadata and check controls. Reviewers and labels now use separate compact rows, the description stays visible without a heading or collapse arrow, and checks start fully collapsed behind one muted chevron. Checks and comments headings keep the label and chevron on the left without counts or dividers; comment sorting stays on the right even when comments are collapsed. Existing comment borders, editing, check links, and Fix actions remain available.

Verified against real GitHub PR #10598: expanding shows all 25 checks and collapsing leaves zero; comment sorting switches while the section stays collapsed. Dark and light layouts, 107 focused tests, and the web typecheck pass. Targeted lint retains one existing array-index-key warning.

Before, whole panel:

original full pull request panel

After, same PR from top through all five comments and the composer:

final whole pull request panel without header dividers or counts

Opening and collapsing all checks:

all checks open and close through one muted chevron

Comment sorting stays available while comments are collapsed:

comment sorting stays on the right while the section is collapsed

Model: gpt-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes the pull-request summary's product defaults: checks are collapsed initially, description collapsing is removed, and comment controls are repositioned. The changes are localized to the web UI but warrant human review because the default user experience changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 56b46e1e-c3ae-4d8a-94e6-67b10a961e6b

📥 Commits

Reviewing files that changed from the base of the PR and between b7b3ef1 and f3ec493.

📒 Files selected for processing (2)
  • apps/web/src/components/pullRequest/PullRequestMarkdown.tsx
  • apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/src/components/pullRequest/PullRequestMarkdown.tsx

Limit details: You’ve used all 10 included reviews currently available.


📝 Walkthrough

Walkthrough

The pull request summary updates metadata spacing, description behavior, checks visibility, comment card styling, and markdown details styling.

Changes

Pull request summary presentation

Layer / File(s) Summary
Summary structure and metadata layout
apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx
Metadata rows use tighter spacing and a two-column layout. The description is no longer collapsible. Section headers, labels, and comment cards use updated spacing, borders, and muted chevrons.
Checks status and visibility
apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx
The Checks section summarizes statuses, hides completed checks by default, scopes expansion state to the pull request, and provides an accessible show/hide control.
Markdown detail styling
apps/web/src/components/pullRequest/PullRequestMarkdown.tsx
Markdown details lose their borders. Detail summary text and icons use reduced contrast.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to f3ec4

This updates pull request summary presentation, including compact metadata and collapsed completed checks, while retaining actionable checks and existing actions. No concrete current-head merge-blocking risk remains.

Suggested reviewers: bil0000, juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies a web pull request summary change and accurately reflects the compacted sections, metadata, and check controls described in the changes.
Description check ✅ Passed The description explains the UI changes, motivation, verification results, and includes before/after images plus interaction videos. It does not use the template headings or checklist, but it contains…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 8, 2026
Comment thread apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Sep 10, 2026
Comment thread apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Comment thread apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Comment thread apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx
@maria-rcks maria-rcks changed the title fix(web): compact pull request metadata and completed checks fix(web): simplify pull request summary sections Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant